Skip to content

Fix #10641 tooltips for layerinfo#10642

Merged
MV88 merged 2 commits intogeosolutions-it:masterfrom
MV88:10641_tooltip
Oct 30, 2024
Merged

Fix #10641 tooltips for layerinfo#10642
MV88 merged 2 commits intogeosolutions-it:masterfrom
MV88:10641_tooltip

Conversation

@MV88
Copy link
Copy Markdown
Contributor

@MV88 MV88 commented Oct 29, 2024

Description

tooltips updated for layer info text

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?

Fix #10641

What is the new behavior?

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@MV88 MV88 added BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch C125-AUSTROCONTROL-2024-SUPPORT labels Oct 29, 2024
@MV88 MV88 added this to the 2024.02.01 milestone Oct 29, 2024
@MV88 MV88 requested a review from allyoucanmap October 29, 2024 17:49
@MV88 MV88 self-assigned this Oct 29, 2024
tdipisa
tdipisa requested changes Oct 29, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@tdipisa tdipisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MV88 let's make things clear. The layer filter is this one:
https://docs.mapstore.geosolutionsgroup.com/en/v2024.01.02/user-guide/filtering-layers/#layer-filter

Make sure the tooltip property name is also consistent with the tool "Update layers titles and descriptions" and doesn't conflict with the one of "Layer Filter". Looking at the translation files it seems confusing.

@MV88
Copy link
Copy Markdown
Contributor Author

MV88 commented Oct 30, 2024

@MV88 let's make things clear. The layer filter is this one: https://docs.mapstore.geosolutionsgroup.com/en/v2024.01.02/user-guide/filtering-layers/#layer-filter

Make sure the tooltip property name is also consistent with the tool "Update layers titles and descriptions" and doesn't conflict with the one of "Layer Filter". Looking at the translation files it seems confusing.

i noticed that the layerinfo was using wrong path, and the correct one was already present.

@MV88 MV88 enabled auto-merge (squash) October 30, 2024 08:49
@MV88 MV88 requested review from tdipisa and removed request for tdipisa October 30, 2024 08:50
@MV88 MV88 merged commit 8e730ae into geosolutions-it:master Oct 30, 2024
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Oct 30, 2024
@MV88
Copy link
Copy Markdown
Contributor Author

MV88 commented Oct 30, 2024

@ElenaGallo please test it in DEV

rmelarab-ngs pushed a commit to ngsllc/MapStore2 that referenced this pull request Nov 5, 2024
@MV88 @rmelarab-ngs
Fix geosolutions-it#10641 tooltips for layerinfo (geosolutions-it#10642)
5967a27 
* Fix geosolutions-it#10641 tooltips for layerinfo

* using correct translations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tdipisa tdipisa tdipisa approved these changes

@allyoucanmap allyoucanmap allyoucanmap approved these changes

Assignees

@MV88 MV88

Labels

C125-AUSTROCONTROL-2024-MapStore

Projects

None yet

Milestone

2024.02.01

Development

Successfully merging this pull request may close these issues.

Update tooltips for TOC toolbar button

3 participants

@MV88 @tdipisa @allyoucanmap