Skip to content

Home and Login Plugins do not appear on the page if the Burger Menu is activated in the context in 2024.01.01 version #10503#10590

Merged
offtherailz merged 6 commits intogeosolutions-it:masterfrom
rowheat02:fix/homeandloginincontext
Oct 4, 2024
Merged

Home and Login Plugins do not appear on the page if the Burger Menu is activated in the context in 2024.01.01 version #10503#10590
offtherailz merged 6 commits intogeosolutions-it:masterfrom
rowheat02:fix/homeandloginincontext

Conversation

@rowheat02
Copy link
Copy Markdown
Contributor

@rowheat02 rowheat02 commented Oct 3, 2024

#10503
In the map of context with plugins login and home. More priority has been given to the sidebar which is a hidden plugin in the context map.
Probable introduction of this issue is from PR https://github.com/geosolutions-it/MapStore2/pull/9841/files
Overriding priority while creating the context for those plugins solves the issue.

Description

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

#10503

What is the current behavior?

#10503

What is the new behavior?
Docs have been updated showing how to override the priority of the plugin home and login

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@rowheat02 rowheat02 self-assigned this Oct 3, 2024
@rowheat02 rowheat02 linked an issue Oct 3, 2024 that may be closed by this pull request
Home and Login Plugins do not appear on the page if the Burger Menu is activated in the context in 2024.01.01 version #10503
Closed
1 task
@rowheat02 rowheat02 added this to the 2024.02.01 milestone Oct 3, 2024
@rowheat02 rowheat02 requested a review from offtherailz October 3, 2024 12:55
offtherailz
offtherailz requested changes Oct 4, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proper position for this documentation is in the login's jsdoc, so it will be available in context's configuration (the "?" icon of plugins links to jsdoc.

Please paly also attention to the syntax you are using.

Use ```javascript or ```js instead of "``` JavaScript"

In order to test it use :

for mkdocs

mkdocs serve as a preview

for JSDoc, the utility jsdoc:test

Here how to

@offtherailz offtherailz added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Oct 4, 2024
@rowheat02 rowheat02 requested a review from offtherailz October 4, 2024 12:10
offtherailz
offtherailz requested changes Oct 4, 2024
View reviewed changes
@offtherailz offtherailz enabled auto-merge (squash) October 4, 2024 15:49
@offtherailz
Copy link
Copy Markdown
Member

offtherailz commented Oct 4, 2024

@ElenaGallo, could you please test this on DEV ? Thank you

@offtherailz offtherailz merged commit 362bf15 into geosolutions-it:master Oct 4, 2024
@ElenaGallo
Copy link
Copy Markdown
Contributor

ElenaGallo commented Oct 8, 2024

@rowheat02 Adding a login, home and hamburger menu plugin to a context, the login and home button is still not visible on the context.

See the attached image and use this context

ok

@rowheat02
Copy link
Copy Markdown
Contributor Author

rowheat02 commented Oct 9, 2024 •
edited
Loading

@ElenaGallo Did you pass plugin configuration

{
    "cfg": {},
    "override": {
        "OmniBar": {
            "priority": 5
        }
    }
}

on home and login plugin.
This PR only updated the docs to get those two plugins in Omnibar.
https://github.com/geosolutions-it/MapStore2/pull/10590/files#diff-279a1b1b58e7d6894598a365d5b464c272df66a874c4fd86de90492f49feac1fR47-R60

image

@ElenaGallo
Copy link
Copy Markdown
Contributor

ElenaGallo commented Oct 9, 2024

@rowheat02 ok, thanks. I'll re-test the issue.

@ElenaGallo
Copy link
Copy Markdown
Contributor

ElenaGallo commented Oct 9, 2024

Test passed, @rowheat02 please backport to 2024.02.xx. Thanks

offtherailz pushed a commit that referenced this pull request Oct 18, 2024
@rowheat02 @offtherailz
Home and Login Plugins do not appear on the page if the Burger Menu i…
a318a2a 
…s activated in the context in 2024.01.01 version #10503 (#10590)
rowheat02 added a commit to rowheat02/MapStore2 that referenced this pull request Nov 5, 2024
@rowheat02
Home and Login Plugins do not appear on the page if the Burger Menu i…
d05308e 
…s activated in the context in 2024.01.01 version geosolutions-it#10503 (geosolutions-it#10590)
tdipisa pushed a commit that referenced this pull request Nov 5, 2024
@rowheat02
Home and Login Plugins do not appear on the page if the Burger Menu i…
45cabef 
…s activated in the context in 2024.01.01 version #10503 (#10590) (#10649)
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@offtherailz offtherailz offtherailz approved these changes

Assignees

@rowheat02 rowheat02

Labels

bug Good first issue Internal

Projects

None yet

Milestone

2024.02.01

Development

Successfully merging this pull request may close these issues.

Home and Login Plugins do not appear on the page if the Burger Menu is activated in the context in 2024.01.01 version

4 participants

@rowheat02 @offtherailz @ElenaGallo @tdipisa