Search by coordinate in 3D mode issue #10063#10576
Merged
offtherailz merged 1 commit intogeosolutions-it:masterfrom Oct 4, 2024
Merged
Search by coordinate in 3D mode issue #10063#10576offtherailz merged 1 commit intogeosolutions-it:masterfrom
offtherailz merged 1 commit intogeosolutions-it:masterfrom
Conversation
rowheat02
commented
Oct 1, 2024
Contributor
Author
There was a problem hiding this comment.
Since viewerOptions coordinates were winning in this part. I don't think we need this in _updateMapPositionFromNewProps as viewerOptions logic is handled in componentDidMount to update the map after saving. @allyoucanmap
Member
There was a problem hiding this comment.
Looking for the reason of that code, I recovered these changes in PR by @allyoucanmap
Now. I tested by trying to save and the positlion looks anyway to be preserved.
So it LGTM.
Member
|
@ElenaGallo, could you please test this on DEV ? Thank you |
Contributor
|
Test passed, @rowheat02 please backport to 2024.02.xx. Thanks |
offtherailz
pushed a commit
that referenced
this pull request
Oct 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixes #10063
vieweOptions had been prioritised in _updateMapPositionFromNewProps which was creating problem before.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#10063
The map did not jump into the searched coordinates in the 3D map.
What is the new behavior?
After the search through coordinate the map jump into that coordinate
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information