geosolutions-it#10127: update tests to enable react-redux 7.x upwards#10142
Merged
MV88 merged 1 commit intogeosolutions-it:masterfrom Aug 29, 2024
Merged
Conversation
Updates tests relying on 'render' returning a reference to enable react-redux 7.x upwards (where some components become stateless and render no longer returns a reference, even though it was successful) On Behalf of DB Systel
Member
|
@fkellner thank you so much for your contribution. We will review as soon as possible. |
Member
|
@MV88, let's evaluate a possible inclusion in 2024.01.01 (waiting for the review). |
1 task
MV88
approved these changes
Aug 29, 2024
Contributor
MV88
left a comment
There was a problem hiding this comment.
LGTM, tests are passing so there are no objections
Contributor
|
@ElenaGallo no specific functional tests are needed for this now. The usual functional test run scheduled for QA for 2024.02.00 is more than enough. |
offtherailz
pushed a commit
that referenced
this pull request
Oct 18, 2024
Updates tests relying on 'render' returning a reference to enable react-redux 7.x upwards (where some components become stateless and render no longer returns a reference, even though it was successful) On Behalf of DB Systel Co-authored-by: Florian Kellner <florian.fl.kellner@deutschebahn.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As described in #10127,
this PR updates tests relying on 'render' returning a reference to enable
react-redux 7.x upwards (where some components become stateless and render
no longer returns a reference, even though it was successful).
Basically, for those tests, the indicator if the render function was successful is
no longer that it returns a reference to a class instance, but that the DOM was modified.
For most tests, this basic check is complemented by more in-depth checks, which were
left unchanged.
Rendering the
MapViewerCmpdid not result in measurable changes to the DOM(the content of the container div stayed an empty string), so instead,
the new test checks that the
onLoadcallback function is being called.What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#10127
What is the new behavior?
Tests still run through regardless of whether
react-redux 6.xor7.xis being used.Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information