fix detail hsv & split text buttons being offscreen#154
Merged
Cvolton merged 2 commits intogeode-sdk:mainfrom Feb 26, 2026
Merged
fix detail hsv & split text buttons being offscreen#154Cvolton merged 2 commits intogeode-sdk:mainfrom
Cvolton merged 2 commits intogeode-sdk:mainfrom
Conversation
Contributor
Author
|
this could very well affect other layers as well but i haven't noticed any other discrepancies |
Member
|
might be better to force ignoreInvisibleChildren to false for these menus instead? this is the solution we went with for most other menus where this is relevant |
Contributor
Author
|
i can do that, i just figured the consistency of all menus having ignoreInvisibleChildren enabled was a better solution |
Contributor
Author
|
updated as requested |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #153
this happens because v5 sets ignoreInvisibleChildren to true by default. however since these two buttons start out as invisible, calling updateLayout on their parent menus does nothing, and so they remain at their default positions, which is far offscreen