fix replaceInput not inheriting number input property#110
Merged
Cvolton merged 1 commit intogeode-sdk:mainfrom Nov 9, 2024
Merged
fix replaceInput not inheriting number input property#110Cvolton merged 1 commit intogeode-sdk:mainfrom
Cvolton merged 1 commit intogeode-sdk:mainfrom
Conversation
|
I dont have 2.207 geode it works in pc :( |
OmgRod
pushed a commit
to OmgRod/NodeIDs
that referenced
this pull request
Nov 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the inputs in SetGroupIDLayer have
m_numberInputenabled by default. when node ids replaces an input with a geode input, this value is not inherited. this results in the input not being cleared upon selecting it when its value is 0 or a non-number string like "Mixed," which is mildly annoying. this issue is now fixedfixes #99