Merged
Conversation
Passing run #2181 ↗︎
Details:
Review all test suite changes for PR #828 ↗︎ |
|||||||||||||||
d1aa4bf to
f4505a9
Compare
…xternal WMTS with time series Now the External WMTS are also working on 3d. Also added support for external WMTS with Time dimension, which can change the time dimension with the UI.
f4505a9 to
de13e67
Compare
pakb
approved these changes
May 16, 2024
Contributor
pakb
left a comment
There was a problem hiding this comment.
That was a lot to add to achieve the wanted result 😮
| this.availableProjections.push(WGS84) | ||
| } | ||
| this.getFeatureInfoCapability = getFeatureInfoCapability | ||
| this.currentYear = currentYear |
Contributor
There was a problem hiding this comment.
does it really make sense to store this value, if we do not react/update the time config whenever it changes?
Contributor
Author
There was a problem hiding this comment.
It is used by the external layer plugin once the capabilities has been loaded, so it is required
Comment on lines
+40
to
+41
| const options = { ...externalWmtsLayerConfig.value.options } | ||
| options.dimensions = { ...options.dimensions } |
Contributor
There was a problem hiding this comment.
Might make sense that we add some cloneDeep functions from Lodash or other library for such cases
Contributor
Author
I went a bit further by enabling time layer in external import as well 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO in separate PR:
Test link