Skip to content

PB-496: Added External WMS time config support#851

Merged
ltshb merged 2 commits intodevelopfrom
bug-PB-496-wms-time-external
May 23, 2024
Merged

PB-496: Added External WMS time config support#851
ltshb merged 2 commits intodevelopfrom
bug-PB-496-wms-time-external

Conversation

@ltshb
Copy link
Contributor

@ltshb ltshb commented May 22, 2024 •
edited
Loading

@github-actions github-actions bot added the bug label May 22, 2024
@cypress
Copy link

cypress bot commented May 22, 2024 •
edited
Loading

Passing run #2250 ↗︎

0 206 20 0 Flakiness 0

Details:

PB-496: Added support for external WMS timed layer feature detection
Project: web-mapviewer Commit: a76f9a8108
Status: Passed Duration: 04:58 💡
Started: May 23, 2024 7:14 AM Ended: May 23, 2024 7:19 AM

Review all test suite changes for PR #851 ↗︎

@ltshb ltshb requested a review from pakb May 22, 2024 07:34
@ltshb ltshb mentioned this pull request May 22, 2024
Merged
2 tasks
@pakb
Copy link
Contributor

pakb commented May 23, 2024

Could you test to add also this timestamp/time to the GetFeatureInfo request?
If I click on a feature in the test link you provided, all years are returned, even though I selected a specific one. Might make sense to try to narrow the GetFeatureInfo too

@ltshb ltshb force-pushed the bug-PB-451-wms-time-enalbed branch from 677b3f6 to 0c4bc9b Compare May 23, 2024 06:19
Base automatically changed from bug-PB-451-wms-time-enalbed to develop May 23, 2024 06:41
@ltshb ltshb force-pushed the bug-PB-496-wms-time-external branch from fb5dd5d to a76f9a8 Compare May 23, 2024 07:10
@ltshb
Copy link
Contributor Author

ltshb commented May 23, 2024

Could you test to add also this timestamp/time to the GetFeatureInfo request? If I click on a feature in the test link you provided, all years are returned, even though I selected a specific one. Might make sense to try to narrow the GetFeatureInfo too

@pakb done

pakb
pakb approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@pakb pakb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! works well

@ltshb ltshb merged commit 2cd1a38 into develop May 23, 2024
@ltshb ltshb deleted the bug-PB-496-wms-time-external branch May 23, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pakb pakb pakb approved these changes

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ltshb @pakb