Skip to content

PB-259: Store sync router clean up#655

Merged
ltshb merged 4 commits intodevelopfrom
feat-PB-259-performance-router
Feb 27, 2024
Merged

PB-259: Store sync router clean up#655
ltshb merged 4 commits intodevelopfrom
feat-PB-259-performance-router

Conversation

@ltshb
Copy link
Contributor

@ltshb ltshb commented Feb 22, 2024

Use the new dispatcher in sync router to ignore dispatch made by router instead
of some local buggy flags.

Test link

@ltshb ltshb force-pushed the feat-PB-259-performance-config-topic branch from b3b37cb to f50fc25 Compare February 22, 2024 10:51
@ltshb ltshb marked this pull request as draft February 22, 2024 10:52
@cypress
Copy link

cypress bot commented Feb 22, 2024

Passing run #743 ↗︎

0 168 21 0 Flakiness 0

Details:

PB-259: solved e2e test race condition
Project: web-mapviewer Commit: f1ed1badf2
Status: Passed Duration: 04:38 💡
Started: Feb 27, 2024 12:33 PM Ended: Feb 27, 2024 12:37 PM

Review all test suite changes for PR #655 ↗︎

@ltshb ltshb force-pushed the feat-PB-259-performance-router branch from 73b7c23 to 064f57e Compare February 22, 2024 12:04
@ltshb ltshb force-pushed the feat-PB-259-performance-config-topic branch 2 times, most recently from bbea68a to 8bdb049 Compare February 26, 2024 05:28
@ltshb ltshb force-pushed the feat-PB-259-performance-router branch from 064f57e to 53f5335 Compare February 26, 2024 05:42
Base automatically changed from feat-PB-259-performance-config-topic to develop February 26, 2024 10:18
@ltshb ltshb force-pushed the feat-PB-259-performance-router branch 7 times, most recently from fc513e2 to 0505137 Compare February 26, 2024 14:06
@ltshb ltshb changed the title PB-259: Router vue performance PB-259: Added dispatcher to all store events Feb 26, 2024
@ltshb ltshb force-pushed the feat-PB-259-performance-router branch 2 times, most recently from a6d918b to 0ea98f9 Compare February 26, 2024 14:23
@ltshb ltshb marked this pull request as ready for review February 26, 2024 14:26
@ltshb ltshb requested a review from pakb February 26, 2024 14:26
@ltshb ltshb changed the title PB-259: Added dispatcher to all store events PB-259: Store sync router clean up Feb 26, 2024
@ltshb ltshb changed the base branch from develop to feat-PB-259-dispatcher February 26, 2024 14:26
@ltshb
Copy link
Contributor Author

ltshb commented Feb 26, 2024

The test failing is solved in next PR #660

@ltshb ltshb force-pushed the feat-PB-259-dispatcher branch from 368e114 to d6aba75 Compare February 27, 2024 11:51
Base automatically changed from feat-PB-259-dispatcher to develop February 27, 2024 12:05
Use the new dispatcher in sync router to ignore dispatch made by router instead
of some local buggy flags.
If a layer as a matching default opacity in the layer url, in the new url
we should to remove the opacity. This was not the case.
`expect` doesn't do retry and therefore the instance the `isLoading` flag could
have not yet been set to false and the test would failed. Now we use cy.wrap
and should that does retries with time out.
@ltshb ltshb force-pushed the feat-PB-259-performance-router branch from fdcdf6a to f1ed1ba Compare February 27, 2024 12:29
@ltshb ltshb merged commit 9912f34 into develop Feb 27, 2024
@ltshb ltshb deleted the feat-PB-259-performance-router branch February 27, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants