Fix legacy parameter layer default opacity#660
Merged
ltshb merged 3 commits intofeat-PB-259-performance-routerfrom Feb 27, 2024
Merged
Fix legacy parameter layer default opacity#660ltshb merged 3 commits intofeat-PB-259-performance-routerfrom
ltshb merged 3 commits intofeat-PB-259-performance-routerfrom
Conversation
Passing run #734 ↗︎
Details:
Review all test suite changes for PR #660 ↗︎ |
|||||||||||||||
If a layer as a matching default opacity in the layer url, in the new url we should to remove the opacity. This was not the case.
4dcffc1 to
4f9f983
Compare
ltkum
approved these changes
Feb 26, 2024
Contributor
ltkum
left a comment
There was a problem hiding this comment.
Looks good to me, and the cypress test looks cleaner too :)
`expect` doesn't do retry and therefore the instance the `isLoading` flag could have not yet been set to false and the test would failed. Now we use cy.wrap and should that does retries with time out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a layer has a matching default opacity in the layer url, in the new url
we should remove the opacity. This was not the case.
Test link