PB-105: Remove menu share spinner and make embed ui similar to import maps#614
Merged
PB-105: Remove menu share spinner and make embed ui similar to import maps#614
Conversation
4d594f6 to
55c7a2e
Compare
Passing run #330 ↗︎
Details:
Review all test suite changes for PR #614 ↗︎ |
|||||||||||||||
- Add rounded corner on bottom right - Add shadow This way it looks similar to the menu
This corner is on the edge of the window and don't need rounding.
This icon change size if in down or right mode
55c7a2e to
8871586
Compare
ltkum
approved these changes
Jan 22, 2024
Contributor
ltkum
left a comment
There was a problem hiding this comment.
Everything seems in order to me.
defineModal in vue 3.4 has been added to the official feature.
ltshb
added a commit
that referenced
this pull request
Jan 23, 2024
ltshb
added a commit
that referenced
this pull request
Jan 24, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also did several menu styling improvements
Test link