Conversation
pakb
approved these changes
Oct 24, 2023
Contributor
pakb
left a comment
There was a problem hiding this comment.
I'm not sure we might not have some issue with bigger tests, such as the geodesic tests.
But if we do not encounter flakiness, that would improve build time when some tests are failing
Reduced the timeout in order to speed tests when they are failings
c40c281 to
599d538
Compare
This to avoid timeout issue on this test on the CI.
599d538 to
29962c4
Compare
060ddbc to
58bbc10
Compare
ltshb
added a commit
that referenced
this pull request
Oct 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduced the timeout in order to speed tests when they are failings
Test link