BGDIINF_SB-2890: Fixing geodesie tests#485
Merged
ltshb merged 5 commits intodevelop-lv95from Oct 25, 2023
Merged
Conversation
78254c0 to
e31a1bb
Compare
e31a1bb to
e8b78dc
Compare
pakb
approved these changes
Oct 25, 2023
Contributor
pakb
left a comment
There was a problem hiding this comment.
It's a bit hard to judge if this will not break other tests than the geodesics as we are based on our LV95 work branch.
It might be a good idea to test this out while being based straight on develop, and see if all tests are green
Comment on lines
+12
to
+16
| /* In headed mode, the tests work perfectly fine even without these waits. In headless mode | ||
| hovewer, they are needed, as else, the mouse click event following may not be registered | ||
| correctly by the Draw and Modify interactions. The reasons for that are still unclear. */ | ||
| const attempt = cy.state('runnable')._currentRetry // from 0 to 5 | ||
| cy.wait(Math.min(750 + 500 * attempt, 1250)) | ||
| // const attempt = cy.state('runnable')._currentRetry // from 0 to 5 | ||
| // cy.wait(Math.min(750 + 500 * attempt, 1250)) |
Contributor
There was a problem hiding this comment.
If this works without this portion, we might want to remove it altogether
Contributor
Author
There was a problem hiding this comment.
Unfortunately without this wait the CI (and also local headless mode) don't pass. I reverted these changes.
On Chrome setting the `sr` query argument result to a primitive js `number` type and not a `Number` instance.
E2E tests are done in both projection so correctly intercept them.
Those test were written for Web Mercator and can only be run in this projection.
The Geodesie test when running in browser make it crash using numTestsKeptInMemory higher than 2 !
e8b78dc to
9de03ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commit messages
Test link