Conversation
It looks like ServiceWorker/Workbox is providing the index HTML page when Firefox is attempting to download the PDF report from service-print3.
…int-from-cache PB-1816: excludes service-print3 from service-worker caching
sommerfe
approved these changes
Jul 7, 2025
ismailsunni
approved these changes
Jul 7, 2025
| new NavigationRoute(createHandlerBoundToURL('index.html'), { allowlist }), | ||
| new NavigationRoute(createHandlerBoundToURL('index.html'), { | ||
| allowlist, | ||
| // exclude print explicitly as SW is sometimes messing with the download URL on Firefox |
Contributor
There was a problem hiding this comment.
Not so obvious at my first read, here, SW means service workers, right?
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 06m 30s |
| Commit |
|
| Committer | Pascal Barth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
20
|
Skipped
|
0
|
Passing
|
254
|
| View all changes introduced in this branch ↗︎ | |
trying to stop ServiceWorker from filling up requests to service-print3 downladURL on Firefox. also removing the setCacheNameDetails call, as it wasn't working properly (only prefixing one of the 3 cache storage). I've manually added the prefix instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test link