Skip to content

PB-1816: narrowing index.html cache definition to current origin only#1375

Merged
pakb merged 1 commit intodevelopfrom
fix-PB-1816-narrow-cache-definition
Jul 7, 2025
Merged

PB-1816: narrowing index.html cache definition to current origin only#1375
pakb merged 1 commit intodevelopfrom
fix-PB-1816-narrow-cache-definition

Conversation

@pakb
Copy link
Contributor

@pakb pakb commented Jul 7, 2025

trying to stop ServiceWorker from filling up requests to service-print3 downladURL on Firefox.

Test link

@github-actions github-actions bot added the bug label Jul 7, 2025
@pakb pakb requested review from ismailsunni and sommerfe July 7, 2025 07:37
@pakb
Copy link
Contributor Author

pakb commented Jul 7, 2025

last PR didn't fix the issue, so I'm trying something different (I need to test that on the DEV bucket so it needs to be merged...)

@cypress
Copy link

cypress bot commented Jul 7, 2025

web-mapviewer    Run #5499

Run Properties:  status check passed Passed #5499  •  git commit 725fc75569: PB-1816: narrowing index.html cache definition to current origin only
Project web-mapviewer
Branch Review fix-PB-1816-narrow-cache-definition
Run status status check passed Passed #5499
Run duration 05m 55s
Commit git commit 725fc75569: PB-1816: narrowing index.html cache definition to current origin only
Committer Pascal Barth
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 20
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 254
View all changes introduced in this branch ↗︎

trying to stop ServiceWorker from filling up requests to service-print3 downladURL on Firefox.

also removing the setCacheNameDetails call, as it wasn't working properly (only prefixing one of the 3 cache storage). I've manually added the prefix instead
Copy link
Contributor

@ismailsunni ismailsunni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pakb pakb force-pushed the fix-PB-1816-narrow-cache-definition branch from ea61ec8 to 725fc75 Compare July 7, 2025 07:43
@pakb pakb merged commit 7721b8f into develop Jul 7, 2025
6 checks passed
@pakb pakb deleted the fix-PB-1816-narrow-cache-definition branch July 7, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants