Conversation
Trying to better convey why the KML couldn't be loaded, to help reduce questions on our helpdesk team about it.
…age-on-deleted-kml PB-1318 : give a better error message on deleted KMLs
…nal-kml-blocked PB-1539: Allow SMS URI in the external KML
the loading state of a KML layer wasn't managed by the drawing module, meaning that the timing of when the KML data was loaded could lead to no features being present on the drawing layer. Very dangerous because that could make user empty their KMLs if they would edit it in this state
…wing-module-with-adminid PB-1548 : fix mismanagement of drawing features if coming with adminId
ltkum
approved these changes
Mar 24, 2025
Contributor
ltkum
left a comment
There was a problem hiding this comment.
as soon as the CI passes, you can merge this :)
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
master
|
| Run status |
|
| Run duration | 01m 38s |
| Commit |
|
| Committer | Pascal Barth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
1
|
Skipped
|
0
|
Passing
|
48
|
| View all changes introduced in this branch ↗︎ | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test link