Conversation
the loading state of a KML layer wasn't managed by the drawing module, meaning that the timing of when the KML data was loaded could lead to no features being present on the drawing layer. Very dangerous because that could make user empty their KMLs if they would edit it in this state
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 01m 40s |
| Commit |
|
| Committer | Pascal Barth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
1
|
Skipped
|
0
|
Passing
|
48
|
| View all changes introduced in this branch ↗︎ | |
ltkum
approved these changes
Mar 24, 2025
Contributor
ltkum
left a comment
There was a problem hiding this comment.
just a quick idea I had while reviewing, but to be fair it's not important nor breaking. It's perfectly mergeable in the current state :)
good job
Comment on lines
+105
to
+109
| watch(hasLoaded, () => { | ||
| if (hasLoaded.value) { | ||
| addKmlToDrawing() | ||
| } | ||
| }) |
Contributor
There was a problem hiding this comment.
would it be a good idea to set a {once: true} parameter to the watcher? hasLoaded is either always true (we had already loaded the layer before entering the drawing module), or false, then true (we enter the drawing module with the admin link or we created a new kml layer when starting to draw.)
If you don't think it's useful, we can avoid that :)
Contributor
Author
There was a problem hiding this comment.
Don't think that would greatly improve perf, and I'd really like to fix this bug ASAP. Let's go with the current state
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the loading state of a KML layer wasn't managed by the drawing module, meaning that the timing of when the KML data was loaded could lead to no features being present on the drawing layer. Very dangerous because that could make user empty their KMLs if they would edit it in this state
Test link