Skip to content

Manage task refs in taskgroup#3914

Merged
fantix merged 1 commit intogeldata:masterfrom
fantix:taskgroup-strong-ref
May 27, 2022
Merged

Manage task refs in taskgroup#3914
fantix merged 1 commit intogeldata:masterfrom
fantix:taskgroup-strong-ref

Conversation

@fantix
Copy link
Copy Markdown
Member

@fantix fantix commented May 27, 2022

https://docs.python.org/3/library/asyncio-task.html#asyncio.create_task
We usually use TaskGroup.create_task() with the assumption that the
enclosing async with block will wait untill all inner tasks complete,
without storing the references of the inner tasks, which can be GC-ed.

Partially reverted #2068

https://docs.python.org/3/library/asyncio-task.html#asyncio.create_task
We usually use `TaskGroup.create_task()` with the assumption that the
enclosing `async with` block will wait untill all inner tasks complete,
without storing the references of the inner tasks, which can be GC-ed.

Partially reverted geldata#2068
@fantix fantix marked this pull request as ready for review May 27, 2022 14:58
@fantix fantix merged commit 868f3d3 into geldata:master May 27, 2022
@fantix fantix deleted the taskgroup-strong-ref branch May 27, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants