Fix a potential memory leak in taskgroup#2068
Merged
1st1 merged 3 commits intogeldata:masterfrom Jan 5, 2021
Merged
Conversation
* This change does not affect the existing behavior of short-lived task groups, but will improve memory usage of long-lived task groups when there are many tasks spawned repeatedly for a long time. * In aiotools, the test case uses a virtual clock that makes asyncio.sleep to deterministically complete instantly, but here it seems not to have such thing. I've reduced the number of repetitions and time scale, but not sure it's stable or not.
1st1
approved these changes
Jan 5, 2021
Member
1st1
left a comment
There was a problem hiding this comment.
lgtm. Thanks for the contribution!
fantix
added a commit
to fantix/edgedb
that referenced
this pull request
May 27, 2022
https://docs.python.org/3/library/asyncio-task.html#asyncio.create_task We usually use `TaskGroup.create_task()` with the assumption that the enclosing `async with` block will wait untill all inner tasks complete, without storing the references of the inner tasks, which can be GC-ed. Partially reverted geldata#2068
fantix
added a commit
that referenced
this pull request
May 27, 2022
https://docs.python.org/3/library/asyncio-task.html#asyncio.create_task We usually use `TaskGroup.create_task()` with the assumption that the enclosing `async with` block will wait untill all inner tasks complete, without storing the references of the inner tasks, which can be GC-ed. Partially reverted #2068
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs geldata/gel-python#140
This change does not affect the existing behavior of short-lived
task groups, but will improve memory usage of long-lived task groups
when there are many tasks spawned repeatedly for a long time.
In aiotools, the test case uses a virtual clock that makes
asyncio.sleep to deterministically complete instantly, but here
it seems not to have such thing. I've reduced the number of
repetitions and time scale, but not sure it's stable or not.