Add Dockerfiles for testing and for a working example#327
Merged
SpamapS merged 4 commits intogearman:masterfrom Nov 13, 2022
Merged
Add Dockerfiles for testing and for a working example#327SpamapS merged 4 commits intogearman:masterfrom
SpamapS merged 4 commits intogearman:masterfrom
Conversation
SpamapS
reviewed
Oct 23, 2021
Member
SpamapS
left a comment
There was a problem hiding this comment.
Wow that's quite a matrix of dockerfiles. I wonder if we should try to reduce some of the duplication. Will ponder.
Member
|
Yeah I think Travis is kind of a dead-end at this point. Well that should
be a fun project for somebody.
…On Sat, Oct 23, 2021 at 7:18 AM Ed Sabol ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In docker/example/gearmand/Dockerfile
<#327 (comment)>:
> @@ -0,0 +1,64 @@
+FROM gearmand/supervisord:latest
From docker/example/supervisord/Dockerfile, as documented in the
README-Docke.md.
I just noticed that none of the Makefiles for building the Docker images
were committed because a .dockerignore prevented it. I'll have to fix
that.
We've also run out of OSS credits for Travis CI. 😒 I emailed their
support desk and asked them for a recurring amount, but I haven't heard
back yet. If they don't, I think we will probably need to switch to GitHub
Workflows....
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#327 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADS6YGSVJ5VWQQM3H7LOW3UIK74BANCNFSM5GRSQX3A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Member
|
Hey @esabol I'm not entirely sure I have time to scrutinize this but it does look interesting. Let's take a look after we get 1.1.20 out. |
Member
|
I played around with these last night and they're pretty handy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@SpamapS wrote:
I meant to add these over a year ago, but I'm just getting around to creating the PR now. Sorry. Better late than never, I hope.