Hi @barlin41k,

Thanks for the PR, but I'm not sure what issue it addresses.

Permissions are checked in MainActivity.java even before starting the service, so it shouldn't be necessary to check them again (unless I'm missing something).

Best regards,

Hi @barlin41k,

Thanks for the PR, but I'm not sure what issue it addresses.

Permissions are checked in MainActivity.java even before starting the service, so it shouldn't be necessary to check them again (unless I'm missing something).

Best regards,

Hi @gdzx,

You're right, the required permissions already checks in MainActivity.java, so I ended up duplicating that logic.

That said, I think try/catch around AudioRecord is still useful because if the user revokes the permission after service has started, it would just crash. The POST_NOTIFICATIONS checks around notify don't really add any value, since calling notify() is safe without the permission. Those can definitely removed.

Best regards,

If the user revokes the permission after service has started, it would just crash.

I don't think this is addressed by your change either, since after the service is started, the same AudioRecord instance is kept in the RecordThread (so it won't pass through your try / catch again).

There is a lot that could be improved in the handling of permissions (like having some UI that can ask the user to grant them, whereas currently the app just doesn't work), but I don't think this PR really improves the situation, sorry.

Since this whole thing happens over adb, can we open a shell and just grant the permission automatically?

Eg with a shell:

adb shell pm grant fr.dzx.audiosource android.permission.POST_NOTIFICATIONS

Currently this just checks if it's granted instead of just granting it.

@e9x Great idea. I implemented it in next. It won't work for some devices, but otherwise it will be a noticeable improvement. Thanks!