Converted Rotate.js operations to ESM modules#285
Merged
Conversation
4 Ops: - ROT-13 - ROT-47 - Rotate left - Rotate right + module containing common functions
Member
|
Thanks very much for this, especially the new tests. I'll start working on a migration script soon, but I suspect it'll be more of a helper than a full solution. We're still going to have to go through every operation manually as there is a lot to change. It's a good opportunity to review and refactor everything though - never a bad idea! My next focus is on the |
BRAVO68WEB
pushed a commit
to BRAVO68WEB/CyberChef
that referenced
this pull request
May 29, 2022
…over-glitch [REVERT] Fixes hover bug Re: gchq#285
BRAVO68WEB
pushed a commit
to BRAVO68WEB/CyberChef
that referenced
this pull request
May 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content
Converted four operations:
Additionally created
lib/Rotate.mjs, which contains shared default options & shared functions.TODO