Fix: Move Magic checks from Escape to Unescape Unicode Characters#2195
Merged
GCHQDeveloper581 merged 3 commits intogchq:masterfrom Feb 20, 2026
Merged
Fix: Move Magic checks from Escape to Unescape Unicode Characters#2195GCHQDeveloper581 merged 3 commits intogchq:masterfrom
GCHQDeveloper581 merged 3 commits intogchq:masterfrom
Conversation
|
|
GCHQDeveloper581
approved these changes
Feb 20, 2026
Contributor
GCHQDeveloper581
left a comment
There was a problem hiding this comment.
Looks good! Thank you for your contribution.
Contributor
|
But I do have one question. Who is Major Anderson? |
Contributor
Author
Haha, good catch! Major Anderson is actually a 'ghost in the keyboard.' In Chinese pinyin input methods, when you haphazardly mash the keys 'dsads', the algorithm auto-completes it to 'da-sai-an-de-sen', which translates to 大-赛-安-德-森. |
mkilijanek
pushed a commit
to mkilijanek/CyberChef
that referenced
this pull request
Feb 23, 2026
Incorporates 37 upstream commits from gchq/CyberChef master including: - Fix: Move Magic checks from Escape to Unescape Unicode Characters (gchq#2195) - Paste spreadsheets as text (gchq#2200) - Fix Roboto Mono font (gchq#2199) - Fix return of buffer for PNG QR image generation (gchq#2125) - Update JIMP (gchq#2171) - Bump v10.22.1 (gchq#2193) - Bump v10.22.0 (gchq#2189) - Fixed Percent delimiter for hex encoding (gchq#2137) - Added ability to paste Images from Clipboard (gchq#1876) - Quoted Printable improvements (gchq#2186) - Fix freeze when output text decoding fails (gchq#1573) - Fix import operations with special chars (gchq#1040) - Add Bech32 encode/decode operations - Various bug fixes and improvements Conflict resolution: - Workflow files: kept Node 24 + actions@v4 (local upgrade) - package.json: kept jsonwebtoken 9.0.0, fixJimpModule postinstall, added upstream 'tag' script - package-lock.json: kept local version (consistent with jimp 1.6.0 install) - sitemap.mjs: kept modern 'with' import assertion syntax - Code.mjs: kept escaped curly brace regex for Node 24 compatibility - newMinorVersion.mjs: added upstream ignoredAuthors constant https://claude.ai/code/session_011xozAMdxys1JF7nLRQsMtg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where the Magic module would incorrectly identify Unicode-escaped strings (e.g.,
\u5927) as needing the Escape Unicode Characters operation instead of Unescape Unicode Characters.The Problem
EscapeUnicodeCharacters.mjshadchecksdefined that matched\uXXXXpatterns. This caused Magic to prioritize "Escaping" already escaped strings.UnescapeUnicodeCharacters.mjshad nochecksdefined, so Magic ignored it.The Fix
checksfromEscapeUnicodeCharacters.mjs.checkstoUnescapeUnicodeCharacters.mjsto detect\u,%u, andU+prefixes.Testing
\u5927\u8D5B\u5B89\u5FB7\u68EE