Skip to content

Feature: Add PGP Operations (WIP)#195

Closed
tlwr wants to merge 3 commits intogchq:masterfrom
tlwr:feature-add-pgp-ops
Closed

Feature: Add PGP Operations (WIP)#195
tlwr wants to merge 3 commits intogchq:masterfrom
tlwr:feature-add-pgp-ops

Conversation

@tlwr
Copy link
Copy Markdown
Contributor

@tlwr tlwr commented Oct 9, 2017

Referencing #6 (wow, very old issue)

@n1474335
Copy link
Copy Markdown
Member

There seem to be some serious issues with using OpenPGP.js in a web worker. There are various hacks, but they're not very pretty. There's also the issue of it being licenced under LGPL, which isn't perfectly compatible with Apache 2. Keybase solves both these issues, so it might make sense to rewrite the PGP ops using that instead.

import HTTPModule from "./HTTP.js";
import ImageModule from "./Image.js";
import JSBNModule from "./JSBN.js";
import PGPModule from "./PublicKey.js";
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should import ./PGP.js.

@tlwr
Copy link
Copy Markdown
Contributor Author

tlwr commented Oct 27, 2017

Thanks for bumping this, I will have a look at porting the operations using the Keybase implementation.

@tlwr tlwr closed this Nov 25, 2017
BRAVO68WEB pushed a commit to BRAVO68WEB/CyberChef that referenced this pull request May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants