Skip to content

address WithBalancerName deleted in grpc v1.46.0#324

Merged
psFried merged 2 commits intogazette:masterfrom
apesternikov:master
Jun 15, 2022
Merged

address WithBalancerName deleted in grpc v1.46.0#324
psFried merged 2 commits intogazette:masterfrom
apesternikov:master

Conversation

@apesternikov
Copy link
Copy Markdown
Contributor

@apesternikov apesternikov commented Jun 9, 2022

address deleted WithBalancerName that was deprecated for 2 years.
See for context:
https://github.com/grpc/grpc-go/releases/tag/v1.46.0
grpc/grpc-go#5232


This change is Reviewable

@apesternikov apesternikov changed the title upgrade grpc to v1.47.0 address WithBalancerName deleted in grpc to v1.46.0 Jun 9, 2022
@apesternikov apesternikov changed the title address WithBalancerName deleted in grpc to v1.46.0 address WithBalancerName deleted in grpc v1.46.0 Jun 9, 2022
Copy link
Copy Markdown
Collaborator

@michaelschiff michaelschiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@psFried psFried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks for the contribution!

@psFried psFried merged commit 0213e03 into gazette:master Jun 15, 2022
michaelschiff pushed a commit to michaelschiff/core that referenced this pull request Jun 16, 2022
* upgrade grpc to v1.47.0 & address deleted WithBalancerName that was deprecated for 2 years grpc/grpc-go#5232

* restore go.mod and go.sum
michaelschiff pushed a commit to michaelschiff/core that referenced this pull request Jun 16, 2022
* upgrade grpc to v1.47.0 & address deleted WithBalancerName that was deprecated for 2 years grpc/grpc-go#5232

* restore go.mod and go.sum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants