Check joint parent link names in Model::Load#726
Conversation
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## sdf10 #726 +/- ##
==========================================
- Coverage 87.81% 87.76% -0.06%
==========================================
Files 65 65
Lines 10403 10409 +6
==========================================
Hits 9135 9135
- Misses 1268 1274 +6
Continue to review full report at Codecov.
|
|
code coverage is dropping because there is redundant error checking |
| // Check an SDF file with the infinite values for joint axis limits. | ||
| // This is a valid file. | ||
| { | ||
| std::string path = pathBase +"/joint_axis_infinite_limits.sdf"; |
There was a problem hiding this comment.
nit: same comment as the sdf11 PR, not sure if this is necessary since the error is now caught in Model and other tests should already have this file covered.
There was a problem hiding this comment.
as I wrote in #727 (comment), I would keep the test
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-03-25-fortress-edifice-citadel/1343/1 |
🦟 Bug fix
Fixes #719 on
sdf10(a separate fix is needed forsdf11and later)Summary
As noted in #710, several example files in the
test/sdf/folder specify non-existent links in the//joint/parentelement, which violates the spec. I added anign sdf --check test/sdf/joint_axis_infinite_limits.sdftest case in b47f9bf, which properly notes the failure, though thesdf::Root::Loadcall inINTEGRATION_joint_axis_domdoes not report an error. To detect the error insdf::Root::Load, I added a check inModel::Loadthat//joint/parentcontains a valid link name and fixed thetest/sdf/files in ce8c032.A different fix will be needed in
sdf11to account for changes in the spec that allow any frame to be named in//joint/parent.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge