Add Joint DOM API to access joint sensors#517
Merged
jennuine merged 4 commits intogazebosim:masterfrom Mar 24, 2021
Merged
Conversation
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
scpeters
reviewed
Mar 18, 2021
| TEST(DOMJoint, Sensors) | ||
| { | ||
| const std::string testFile = | ||
| sdf::testing::TestFile("sdf", "joint_sensors.sdf"); |
Collaborator
Author
There was a problem hiding this comment.
I always forget to add the sdf file 🤦🏾♂️ . Added in 8d50882
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
jennuine
approved these changes
Mar 24, 2021
Collaborator
jennuine
left a comment
There was a problem hiding this comment.
LGTM! One minor suggestion
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
mjcarroll
pushed a commit
that referenced
this pull request
Aug 26, 2021
* Add Joint DOM API to access joint sensors Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> Co-authored-by: Jenn Nguyen <jenn@openrobotics.org>
azeey
pushed a commit
to azeey/sdformat
that referenced
this pull request
Oct 27, 2021
* Add Joint DOM API to access joint sensors Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * Add missing file Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * modified Joint::SensorNameExists Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> Co-authored-by: Jenn Nguyen <jenn@openrobotics.org>
Merged
azeey
pushed a commit
that referenced
this pull request
Oct 28, 2021
* Add Joint DOM API to access joint sensors Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * Add missing file Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * modified Joint::SensorNameExists Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> Co-authored-by: Jenn Nguyen <jenn@openrobotics.org>
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-01-10/1228/1 |
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-03-25-fortress-edifice-citadel/1343/1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
This adds
sdf::Joint::SensorCount,sdf::Joint::SensorByIndex,sdf::Joint::SensorNameExists,sdf::Joint::SensorByName.Test it
Run tests
Checklist
sh tools/code_check.sh)another open pull request
to support the maintainers
Note to maintainers: Remember to use Squash-Merge