Conversation
ahcorde
left a comment
There was a problem hiding this comment.
Do you mind to add the Python binding ? or if you dont' have time just open an issue.
|
And additional note. Probably you should close all PR which are targeting harmonic, then we will backport them as required. @azeey. other thoughts on this ? |
Added all the pybind and a bunch of tests for everything as well: |
ahcorde
left a comment
There was a problem hiding this comment.
Just some small nits, but LGTM
8bea333 to
341727d
Compare
|
Can you merge from |
Squashing commits to make requested target of main with backports to harmonic. Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
Co-authored-by: Addisu Z. Taddese <addisuzt@intrinsic.ai> Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
Co-authored-by: Steve Peters <computersthatmove@gmail.com> Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
341727d to
07c1573
Compare
Done! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1418 +/- ##
==========================================
+ Coverage 92.45% 92.48% +0.03%
==========================================
Files 134 137 +3
Lines 17820 17954 +134
==========================================
+ Hits 16475 16605 +130
- Misses 1345 1349 +4 ☔ View full report in Codecov by Sentry. |
|
Has the issue with COM being different from the geometric center been addressed? |
Not sure, @scpeters any particular thoughts? |
scpeters
left a comment
There was a problem hiding this comment.
Has the issue with COM being different from the geometric center been addressed?
Not sure, @scpeters any particular thoughts?
apologies, I was working on it and then decided I wanted to implement gz sdf --print --expand-auto-inertials in #1422 instead of manually computing a bunch of inertial values
I see two options for defining the origin of the cone shape for purposes of object placement in SDFormat (a different origin may be assumed in other parts of our API, but this is just focusing on SDFormat):
-
Shape origin at the center of the cone's bounding box (or bounding cylinder). In this case, placing a cone with length
Lwith base down on a ground plane at Z=0 can be done by setting the initial Z pose of the cone toL/2. This would allow the cone to be placed in the same way as a cylinder. (Example world file placing multiple unit shapes with the same initial Z poses in scpeters@3ad5655). -
Shape origin at the centroid of a cone with uniform density. For a uniform-density cone with length
L, the centroid isL/4above the base, orL/4towards the base from the center of the bounding cylinder.
I prefer option 1 for the following reasons:
-
I think option 1 is more intuitive for placing geometry since it allows similar placement of a cone and cylinder with the same poses (it will place the base of a cone in the same location as a cylinder base).
-
While option 2 does not require specifying an
//inertial/posevalue when the code has uniform density, I think is not worth the trade-off for making geometry placement less intuitive by not following the pattern used by the cylinder, the most similar shape to a cone. This has little value for static shapes (which have no inertial properties) and for objects with non-uniform density (which will need the//inertial/poseto be specified anyway).
Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
9e23185 to
ec0f10f
Compare
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
left a comment
There was a problem hiding this comment.
sorry I missed updating one test
Co-authored-by: Steve Peters <computersthatmove@gmail.com> Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
No worries, thanks for helping! |
Co-authored-by: Steve Peters <computersthatmove@gmail.com> Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
* Backport: Add cone shape to SDFormat spec (#1418) Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com> Co-authored-by: Steve Peters <computersthatmove@gmail.com>
* Backport: Add cone shape to SDFormat spec (gazebosim#1418) Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com> Co-authored-by: Steve Peters <computersthatmove@gmail.com>
* Backport: Add cone shape to SDFormat spec (gazebosim#1418) Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com> Co-authored-by: Steve Peters <computersthatmove@gmail.com>
🦟 Bug fix
Summary
This helps add the missing cone geometry for primitive/basic parametric shapes:
And is also valuable for visualizations of emitters/source that typically have conic-based spread as seen in this acoustic attack on an IMU by showing the affected area:
Associated PRs:
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.