Using math::SpeedLimiter on the ackermann_steering controller.#837
Merged
scpeters merged 2 commits intoign-gazebo4from Jun 3, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## ign-gazebo4 #837 +/- ##
==============================================
Coverage ? 65.66%
==============================================
Files ? 240
Lines ? 17788
Branches ? 0
==============================================
Hits ? 11681
Misses ? 6107
Partials ? 0
Continue to review full report at Codecov.
|
caguero
reviewed
May 28, 2021
Contributor
caguero
left a comment
There was a problem hiding this comment.
Nit: I think we don't need the #include <limits> anymore.
Signed-off-by: LolaSegura <lsegura@ekumenlabs.com>
Signed-off-by: LolaSegura <lsegura@ekumenlabs.com>
61859e1 to
ea8b861
Compare
Contributor
Author
@caguero you are right, I deleted it. Thanks for catching that. |
scpeters
approved these changes
Jun 3, 2021
Member
|
looks good to me; I think the only test failures are flaky |
Merged
chapulina
pushed a commit
that referenced
this pull request
Jul 26, 2022
Signed-off-by: LolaSegura <lsegura@ekumenlabs.com>
9 tasks
chapulina
added a commit
that referenced
this pull request
Jul 26, 2022
* Ackermann Steering Plugin (#618) Signed-off-by: Kevin <ak619@lafn.org> Co-authored-by: Kevin <ak619@lafn.org> Co-authored-by: Louise Poubel <louise@openrobotics.org> * Using math::SpeedLimiter on the ackermann_steering controller. (#837) Signed-off-by: LolaSegura <lsegura@ekumenlabs.com> * Add Tf publishing to AckermannSteering system (#1576) Signed-off-by: Andrew Ealovega <Andrew@Ealovega.dev> Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: knoedler <knoedler@dslextreme.com> Co-authored-by: Kevin <ak619@lafn.org> Co-authored-by: LolaSegura <48759425+LolaSegura@users.noreply.github.com> Co-authored-by: Andrew Ealovega <andyblarblar@gmail.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: LolaSegura lsegura@ekumenlabs.com
Summary
This replace the ackermann_steering controller speed limiter class for the one implemented in ignition math. Part of #810.
Checklist
codecheckpassed (See contributing)🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸