Merged
Conversation
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com> Co-authored-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
cc49d85 to
2b5b259
Compare
ahcorde
previously requested changes
Aug 27, 2021
Contributor
ahcorde
left a comment
There was a problem hiding this comment.
I fixed some issues, but I think it requires some releases. msgs6 ?
2b5b259 to
fa7306e
Compare
chapulina
added a commit
that referenced
this pull request
Sep 9, 2021
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-sensors4 #153 +/- ##
================================================
+ Coverage 76.16% 76.52% +0.35%
================================================
Files 23 23
Lines 2396 2458 +62
================================================
+ Hits 1825 1881 +56
- Misses 571 577 +6
Continue to review full report at Codecov.
|
Also fix deprecation warning. Signed-off-by: Louise Poubel <louise@openrobotics.org>
af33680 to
c0f9ecf
Compare
iche033
approved these changes
Sep 10, 2021
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-01-10/1228/1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port ign-sensors3 to ign-sensors4
Branch comparison: ign-sensors4...ign-sensors3
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)