Skip to content

Respect GZ_PYTHON_INSTALL_PATH as cmake arg#692

Merged
scpeters merged 2 commits intogz-math9from
scpeters/respect_python_install_path
Oct 3, 2025
Merged

Respect GZ_PYTHON_INSTALL_PATH as cmake arg#692
scpeters merged 2 commits intogz-math9from
scpeters/respect_python_install_path

Conversation

@scpeters
Copy link
Copy Markdown
Member

@scpeters scpeters commented Sep 8, 2025

🦟 Bug fix

Similar to gazebosim/sdformat#1586.

Summary

Adapted from gazebosim/sdformat#1586.

The PR adds the ability to set the GZ_PYTHON_INSTALL_PATH from CMake arguments by not overriding it if it is set. This is useful for paths injected by the different package managers and distributions.

One use case is for the ROS vendor packages where the Python path is controlled by an ament_python helper call.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Generated-by: Remove this if GenAI was not used.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

Similar to gazebosim/sdformat#1586.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters requested a review from j-rivero September 8, 2025 18:10
@github-actions github-actions bot added the 🪵 jetty Gazebo Jetty label Sep 8, 2025
@scpeters scpeters mentioned this pull request Sep 19, 2025
7 tasks
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Sep 19, 2025
@scpeters scpeters merged commit b93001e into gz-math9 Oct 3, 2025
13 checks passed
@scpeters scpeters deleted the scpeters/respect_python_install_path branch October 3, 2025 23:07
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Oct 3, 2025
scpeters added a commit that referenced this pull request Oct 8, 2025
Similar to gazebosim/sdformat#1586.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters added a commit that referenced this pull request Oct 8, 2025
Similar to gazebosim/sdformat#1586.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters added a commit that referenced this pull request Oct 8, 2025
Similar to gazebosim/sdformat#1586.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🪵 jetty Gazebo Jetty

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants