Unify Python3_Development_FOUND checks#663
Merged
Conversation
The value of this variable may change if other code paths call find_package(Python3), so move the warning to be co-located with the add_subdirectory call. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
commented
Feb 10, 2025
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
azeey
approved these changes
Feb 11, 2025
This was referenced Feb 13, 2025
Member
Author
|
I opened #665 to test CI with prereleases, and it has the same commit hashes, so it is rewriting the build status if these CI checks pass, then we know the cmake warning will be fixed by the next gz-cmake3 stable release |
Member
Author
fixed! I will merge this, when we are ready for a stable release of gz-cmake3 |
Member
Author
|
@osrf-jenkins run tests please |
Member
Author
|
CI is fixed now that gazebosim/gz-cmake#473 has been released, merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes hidden warnings when python development libraries are not found, backport of #662
Summary
The value of Python3_Development_FOUND may change if other code paths call find_package(Python3), so move the warning to be co-located with the add_subdirectory call. Otherwise python bindings may be silently ignored.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.