Conversation
* Don't install python3-distutils on 24.04 * Remove old ruby cmake code Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## gz-math7 #590 +/- ##
=========================================
Coverage 94.11% 94.11%
=========================================
Files 146 146
Lines 9809 9809
=========================================
Hits 9232 9232
Misses 577 577 ☔ View full report in Codecov by Sentry. |
azeey
approved these changes
May 2, 2024
.github/ci/packages-jammy.apt
Outdated
| @@ -0,0 +1 @@ | |||
| python3-distutils | |||
Contributor
There was a problem hiding this comment.
I don't think we need it in Jammy either (see gazebosim/gz-sim#2374 (comment))
Member
Author
There was a problem hiding this comment.
you're right; I knew we need it for focal and wasn't thinking clearly about jammy. removed in 355780f
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Attempting to enable CI on 24.04 for Harmonic (partial backport of #587)
Summary
The python3-distutils package is not available on 24.04, but we only use it in a codepath for old versions of cmake. Since 24.04 has a new enough version of cmake, that package is moved from the generic
package.aptfile to distro-specificpackages-focal.aptandpackages-jammy.aptfiles.Test it
Observe CI results.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.