Enable 24.04 CI, remove distutils dependency#587
Merged
Conversation
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Part of gazebosim/gz-cmake#350. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Also don't need to install python3-distutils anymore. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
9 tasks
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
j-rivero
approved these changes
Apr 18, 2024
29 tasks
scpeters
added a commit
to gazebo-release/gz-math8-release
that referenced
this pull request
Apr 18, 2024
No longer needed as of gazebosim/gz-math#587. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
added a commit
to gazebo-release/gz-math8-release
that referenced
this pull request
Apr 18, 2024
No longer needed as of gazebosim/gz-math#587. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
This was referenced Apr 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Attempting to enable CI on 24.04
Summary
The
python3-distutilspackage is not available on 24.04, but we only use it in a codepath for old versions of cmake. Since we are already requiring cmake 3.22.1 in gz-cmake4, we can require that version in gz-math8 as well and remove code for old versions of cmake.This isn't quite working yet due to an error using
pipwith python 3.12 on Noble.Test it
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.