Remove the use of numeric_limits in appendToStream test#553
Merged
Remove the use of numeric_limits in appendToStream test#553
Conversation
The numeric_limits use in the appendToStream test has been a headache to deal with in the different platforms and arches. Since it does not seem to provide extra value on testing the feature, reduce the maintenance code by removing it. Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
ahcorde
approved these changes
Aug 30, 2023
Codecov Report
@@ Coverage Diff @@
## gz-math7 #553 +/- ##
=========================================
Coverage 94.16% 94.16%
=========================================
Files 145 145
Lines 9774 9774
=========================================
Hits 9204 9204
Misses 570 570 |
mjcarroll
approved these changes
Sep 7, 2023
mjcarroll
reviewed
Sep 7, 2023
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Member
|
https://github.com/Mergifyio backport ign-math6 |
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 29, 2025
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org> Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai> Co-authored-by: Michael Carroll <michael@openrobotics.org> Co-authored-by: Michael Carroll <mjcarroll@intrinsic.ai> (cherry picked from commit 6460f7c) # Conflicts: # src/Helpers_TEST.cc
scpeters
pushed a commit
that referenced
this pull request
Sep 29, 2025
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org> Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai> Co-authored-by: Michael Carroll <michael@openrobotics.org> Co-authored-by: Michael Carroll <mjcarroll@intrinsic.ai> (cherry picked from commit 6460f7c)
scpeters
pushed a commit
that referenced
this pull request
Sep 29, 2025
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org> Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai> Co-authored-by: Michael Carroll <michael@openrobotics.org> Co-authored-by: Michael Carroll <mjcarroll@intrinsic.ai> (cherry picked from commit 6460f7c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The numeric_limits use in the appendToStream test has been a headache to deal with in the different platforms and arches (see previous patches in this same repository). Since it does not seem to provide extra/critical value to my eyes on the testing the feature, reduce the maintenance cost by removing it and leave other string approaches.