Skip to content

Cherry-pick #480: Add option to skip pybind11 and SWIG #528

Merged
scpeters merged 2 commits intoign-math6from
azeey/cherrypick_480
Apr 6, 2023
Merged

Cherry-pick #480: Add option to skip pybind11 and SWIG #528
scpeters merged 2 commits intoign-math6from
azeey/cherrypick_480

Conversation

@azeey
Copy link
Copy Markdown
Contributor

@azeey azeey commented Apr 5, 2023

🦟 Bug fix

Summary

Backport #480 so we have an easy way of disabling pybind11. The plan is to disable pybind11 by default on windows in a followup PR.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Rebase-Merge.

Add option to skip pybind11 and SWIG (#480)
5130c5c 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@github-actions github-actions bot added 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Apr 5, 2023
@azeey azeey mentioned this pull request Apr 5, 2023
Merged
8 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 5, 2023 •
edited
Loading

Codecov Report

Merging #528 (6f64808) into ign-math6 (27cdb93) will not change coverage.
The diff coverage is n/a.

❗ Current head 6f64808 differs from pull request most recent head 5034fce. Consider uploading reports for the commit 5034fce to get more accurate results

@@            Coverage Diff             @@
##           ign-math6     #528   +/-   ##
==========================================
  Coverage      99.68%   99.68%           
==========================================
  Files             73       73           
  Lines           6918     6918           
==========================================
  Hits            6896     6896           
  Misses            22       22

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

scpeters
scpeters approved these changes Apr 5, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good; please rebase and merge

Disable pybind11 on windows by default (#529)
5034fce 
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@scpeters scpeters enabled auto-merge (rebase) April 6, 2023 18:37
@scpeters
Copy link
Copy Markdown
Member

scpeters commented Apr 6, 2023

auto-rebase-and-merge enabled

@scpeters scpeters merged commit 4bb6a73 into ign-math6 Apr 6, 2023
@scpeters scpeters deleted the azeey/cherrypick_480 branch April 6, 2023 21:54
@azeey azeey mentioned this pull request Jun 6, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scpeters scpeters scpeters approved these changes

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995 adityapande-1995 is a code owner

Assignees

No one assigned

Labels

🏰 citadel Ignition Citadel 🏯 fortress Ignition Fortress

Projects

Core development
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@azeey @scpeters @osrf-triage