Rename the python library as gz.math7#503
Merged
Conversation
added 6 commits
September 14, 2022 00:29
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Codecov Report
@@ Coverage Diff @@
## gz-math7 #503 +/- ##
=========================================
Coverage 99.70% 99.70%
=========================================
Files 77 77
Lines 7007 7007
=========================================
Hits 6986 6986
Misses 21 21 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Member
|
we'll need to make a prerelease after this is merged and update downstream python bindings in sdformat |
azeey
approved these changes
Sep 15, 2022
Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
2 tasks
j-rivero
pushed a commit
to gazebosim/sdformat
that referenced
this pull request
Sep 15, 2022
Adapting the code to the change in gazebosim/gz-math#503 Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
This was referenced Sep 15, 2022
Contributor
|
It's definitely good to have the option to select the particular version. However, what is the maintenance plan for this? If there is no way for downstream code to use some convenience like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
Allow side-by-side installations of python bindings by renaming the library to include the version in the name. From
ignition.mathorgz.mathtogz.math7.Particularly, the current approach is causing problems since it conflicts with
gz-math6bindings since both install inignition/mathpath in the filesystem. This is blocking the installation of Fortress + Garden side-by-side.Checklist
codecheckpassed (See contributing)