Backport newest appendToStream functions#453
Merged
Conversation
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-math6 #453 +/- ##
==========================================
Coverage 99.65% 99.65%
==========================================
Files 67 67
Lines 6392 6400 +8
==========================================
+ Hits 6370 6378 +8
Misses 22 22
Continue to review full report at Codecov.
|
adityapande-1995
approved these changes
Jul 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Part of
Backports the final
appendToStreamfunctions after these 2 PRs:Summary
While creating a
Matrix6class, I thought I'd add it toign-math6, but with the updates that have been made toMatrix[3|4]onmain. One of them requires the use of theappendToStreamfunction, which was added tomainin #206 and improved in #376.I'm not backporting the uses of that function that were introduced in
main, because they aren't backwards compatible. I'll use the function in theMatrix6PR that is coming up next.Test it
Run the added tests.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸