Conversation
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## main #376 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 65 65
Lines 6103 6111 +8
=======================================
+ Hits 6081 6089 +8
Misses 22 22
Continue to review full report at Codecov.
|
azeey
left a comment
There was a problem hiding this comment.
Looks great! Do you mind adding checks to the OperatorStreamOut test of each of these classes to ensure that the precision set on the stream object is used properly? Right now the tests only cover appendToStream for individual numbers.
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
|
azeey
left a comment
There was a problem hiding this comment.
LGTM with green CI! See #374 (review) about OrientedBox_TEST.
Thanks! 2560b0b |
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
🦟 Bug fix
Part of gazebosim/sdformat#790
(See section (2) of gazebosim/sdformat#790 (comment))
Summary
The output stream would change the value when calling
precision(). This causes issues changing the precision of the output stream.For example,
Since there doesn't seem to be a clear reason to why the value is changed and the default precision is already 6, I've deprecated the function that changes the value
appendToStream(std::ostream &_out, T _number, int _precision)to be replaced withappendToStream(std::ostream &_out, T _number).Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.