Skip to content

ign -> gz Macro Migration : gz-math#437

Merged
chapulina merged 9 commits intomainfrom
macro_migration
Jun 17, 2022
Merged

ign -> gz Macro Migration : gz-math#437
chapulina merged 9 commits intomainfrom
macro_migration

Conversation

@methylDragon
Copy link
Copy Markdown
Contributor

@methylDragon methylDragon commented Jun 6, 2022

@methylDragon methylDragon requested a review from scpeters as a code owner June 6, 2022 21:43
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 6, 2022
@methylDragon methylDragon mentioned this pull request Jun 6, 2022
Closed
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Jun 7, 2022
@chapulina chapulina self-requested a review June 7, 2022 00:01
@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label Jun 7, 2022
chapulina
chapulina suggested changes Jun 7, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this will break downstream and will need to be merged in sync, how about also tackling the remaining IGN_ variables in this PR? I think it's mainly the IGN_*_SIZE_Ts in Helpers.hh

@methylDragon
Copy link
Copy Markdown
Contributor Author

methylDragon commented Jun 7, 2022 •
edited
Loading

Since this will break downstream and will need to be merged in sync, how about also tackling the remaining IGN_ variables in this PR? I think it's mainly the IGN_*_SIZE_Ts in Helpers.hh

I was thinking of doing that, but I'm not sure how we want to do it.

static const size_t GZ_ZERO_SIZE_T  = 0u;
constexpr auto IGN_ZERO_SIZE_T = &GZ_ZERO_SIZE_T;

?

@methylDragon
Copy link
Copy Markdown
Contributor Author

methylDragon commented Jun 7, 2022

Tick-tocked! 1a32dfc

chapulina
chapulina approved these changes Jun 9, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

methylDragon and others added 9 commits June 17, 2022 11:18
@methylDragon
Migrate macros
e8e5585 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Update migration guide to mention header-dependent macros
f0bec8f 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Fold in some unrelated comment changes
6a0569f 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Tick-tock pybind methods
6b34caf 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Ticktock IGN_*_SIZE_T and IGN_MASSMATRIX3_DEFAULT_TOLERANCE
c1d3f68 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Migrate forward ported macros
2463260 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@chapulina @methylDragon
new IGN_PI
df13902 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@methylDragon
Tick-tock IGNZEROSIZET python binding
4865e74 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Migrate IGNITION_MATH_VISIBLE macros from rebase
a52fd2c 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Copy link
Copy Markdown
Contributor Author

methylDragon commented Jun 17, 2022

@osrf-jenkins run tests please!

@chapulina chapulina enabled auto-merge (squash) June 17, 2022 21:56
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 17, 2022 •
edited
Loading

Codecov Report

Merging #437 (a52fd2c) into main (be960a6) will not change coverage.
The diff coverage is 97.91%.

@@           Coverage Diff           @@
##             main     #437   +/-   ##
=======================================
  Coverage   99.69%   99.69%           
=======================================
  Files          73       73           
  Lines        6567     6567           
=======================================
  Hits         6547     6547           
  Misses         20       20
Impacted Files Coverage Δ
include/gz/math/Angle.hh 100.00% <ø> (ø)
include/gz/math/AxisAlignedBox.hh 100.00% <ø> (ø)
include/gz/math/Inertial.hh 100.00% <ø> (ø)
include/gz/math/Pose3.hh 100.00% <ø> (ø)
include/gz/math/SemanticVersion.hh 100.00% <ø> (ø)
include/gz/math/Temperature.hh 100.00% <ø> (ø)
src/Frustum.cc 99.32% <ø> (ø)
src/Angle.cc 89.09% <66.66%> (ø)
include/gz/math/Filter.hh 100.00% <100.00%> (ø)
include/gz/math/Helpers.hh 100.00% <100.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be960a6...a52fd2c. Read the comment docs.

@chapulina chapulina merged commit 6bb7586 into main Jun 17, 2022
@chapulina chapulina deleted the macro_migration branch June 17, 2022 22:07
adityapande-1995 pushed a commit that referenced this pull request Jun 22, 2022
@methylDragon @chapulina @adityapande-1995
ign -> gz Macro Migration : gz-math (#437)
d4ca4c4 
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: Louise Poubel <louise@openrobotics.org>

Co-authored-by: Louise Poubel <louise@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scpeters scpeters Awaiting requested review from scpeters scpeters is a code owner

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995 adityapande-1995 is a code owner

1 more reviewer

@chapulina chapulina chapulina approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo. needs upstream release Blocked by a release of an upstream library

Projects

Core development
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@methylDragon @chapulina @osrf-triage