Skip to content

Fixed Jammy CI#384

Merged
scpeters merged 2 commits intoign-math6from
ahcorde/6/fix_jammy
Mar 7, 2022
Merged

Fixed Jammy CI#384
scpeters merged 2 commits intoign-math6from
ahcorde/6/fix_jammy

Conversation

@ahcorde
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde commented Mar 7, 2022

Signed-off-by: ahcorde ahcorde@gmail.com

🦟 Bug fix

Fixes #383

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde
Fixed Jammy CI
dd1abe8 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from scpeters as a code owner March 7, 2022 14:33
@ahcorde ahcorde self-assigned this Mar 7, 2022
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Mar 7, 2022
@ahcorde ahcorde mentioned this pull request Mar 7, 2022
Closed
@ahcorde
try again
87f3278 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde mentioned this pull request Mar 7, 2022
Merged
7 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 7, 2022 •
edited
Loading

Codecov Report

Merging #384 (87f3278) into ign-math6 (d5155d2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-math6     #384   +/-   ##
==========================================
  Coverage      99.65%   99.65%           
==========================================
  Files             67       67           
  Lines           6380     6380           
==========================================
  Hits            6358     6358           
  Misses            22       22

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5155d2...87f3278. Read the comment docs.

@scpeters scpeters merged commit 6340f89 into ign-math6 Mar 7, 2022
@scpeters scpeters deleted the ahcorde/6/fix_jammy branch March 7, 2022 17:19
chapulina added a commit to gazebosim/gz-sim that referenced this pull request Apr 8, 2022
@chapulina
Port fix from gazebosim/gz-math#384
5ef736d 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@traversaro traversaro mentioned this pull request Apr 30, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scpeters scpeters scpeters approved these changes

Assignees

@ahcorde ahcorde

Labels

🏰 citadel Ignition Citadel 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress Gazebo 1️1️ Dependency of Gazebo classic version 11

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Jammy CI now failing for ign-math6

4 participants

@ahcorde @scpeters @j-rivero @osrf-triage