Reduce pybind11 compilation memory part 3#382
Merged
ahcorde merged 9 commits intogazebosim:ign-math6from Mar 7, 2022
Merged
Conversation
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-math6 #382 +/- ##
============================================
Coverage ? 99.65%
============================================
Files ? 67
Lines ? 6380
Branches ? 0
============================================
Hits ? 6358
Misses ? 22
Partials ? 0 Continue to review full report at Codecov.
|
ahcorde
approved these changes
Mar 7, 2022
ahcorde
previously requested changes
Mar 7, 2022
Contributor
ahcorde
left a comment
There was a problem hiding this comment.
I added this line
find_package(Python3 REQUIRED COMPONENTS Interpreter Development)
before find pybind11 and Jammy CI is fixed
Contributor
|
ahcorde
approved these changes
Mar 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Follow-up to #371 and #373.
Summary
This continues moving template instantiations from _ignition_math_pybind11.cc to a separate translation unit for templates in each of the following header files:
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.