Skip to content

Move SWIG interfaces from python to ruby#354

Merged
chapulina merged 18 commits intoign-math6from
ahcorde/pybind11/removeSWIG
Dec 30, 2021
Merged

Move SWIG interfaces from python to ruby#354
chapulina merged 18 commits intoign-math6from
ahcorde/pybind11/removeSWIG

Conversation

@ahcorde
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde commented Dec 30, 2021

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

Summary

This PR removes SWIG python interfaces

Require:

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from scpeters as a code owner December 30, 2021 13:09
@ahcorde ahcorde self-assigned this Dec 30, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 30, 2021

Codecov Report

Merging #354 (6b8609a) into ign-math6 (2926fb9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-math6     #354   +/-   ##
==========================================
  Coverage      99.65%   99.65%           
==========================================
  Files             67       67           
  Lines           6380     6380           
==========================================
  Hits            6358     6358           
  Misses            22       22           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2926fb9...6b8609a. Read the comment docs.

@chapulina chapulina changed the title Removed SWIG python interfaces Move SWIG interfaces from python to ruby Dec 30, 2021
Copy link
Copy Markdown
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're just missing the SphericalCoordinates migration to pybind11.

Adding a cross-reference link to the issue about enabling these SWIG files:

Base automatically changed from ahcorde/pybind11/vector3Stats to ign-math6 December 30, 2021 17:25
@chapulina chapulina added Gazebo 1️1️ Dependency of Gazebo classic version 11 scripting Scripting interfaces to Ignition 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Dec 30, 2021
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Copy link
Copy Markdown
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ That was an impressive number of PRs merged in a short time 😄

@chapulina
Copy link
Copy Markdown
Contributor

I think we can dismiss the ABI checker, since we're not promising ABI stability of the python shared libraries.

@chapulina chapulina merged commit d74c2e9 into ign-math6 Dec 30, 2021
@chapulina chapulina deleted the ahcorde/pybind11/removeSWIG branch December 30, 2021 23:39
@osrf-triage
Copy link
Copy Markdown

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏰 citadel Ignition Citadel 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress Gazebo 1️1️ Dependency of Gazebo classic version 11 scripting Scripting interfaces to Ignition

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants