Added Vector3Stats pybind11 interface#351
Merged
Conversation
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
…itionrobotics/ign-math into ahcorde/pybind11/signalstats
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
Codecov Report
@@ Coverage Diff @@
## ign-math6 #351 +/- ##
==========================================
Coverage 99.65% 99.65%
==========================================
Files 67 67
Lines 6380 6380
==========================================
Hits 6358 6358
Misses 22 22 Continue to review full report at Codecov.
|
chapulina
approved these changes
Dec 30, 2021
Contributor
chapulina
left a comment
There was a problem hiding this comment.
LGTM, but the PR this one builds on top still has failing tests
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
8 tasks
…to ahcorde/pybind11/vector3Stats
…nitionrobotics/ign-math into ahcorde/pybind11/vector3Stats
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ahcorde ahcorde@gmail.com
🎉 New feature
Summary
This PR creates a Vector3Stats Pybind11 interface
Require:
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.