Skip to content

Added Matrix4 pybind11 interface#337

Merged
chapulina merged 7 commits intoign-math6from
ahcorde/pybind11/matrix4
Dec 29, 2021
Merged

Added Matrix4 pybind11 interface#337
chapulina merged 7 commits intoign-math6from
ahcorde/pybind11/matrix4

Conversation

@ahcorde
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde commented Dec 24, 2021

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

Summary

This PR creates a Matrix4 Pybind11 interface

Require

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from scpeters as a code owner December 24, 2021 12:58
@ahcorde ahcorde self-assigned this Dec 24, 2021
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🌱 garden Ignition Garden 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Dec 24, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 24, 2021

Codecov Report

Merging #337 (8373140) into ign-math6 (3d1d076) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-math6     #337   +/-   ##
==========================================
  Coverage      99.65%   99.65%           
==========================================
  Files             67       67           
  Lines           6380     6380           
==========================================
  Hits            6358     6358           
  Misses            22       22           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d1d076...8373140. Read the comment docs.

@chapulina chapulina added the scripting Scripting interfaces to Ignition label Dec 27, 2021
Copy link
Copy Markdown
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
Copy link
Copy Markdown
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with happy CI

ahcorde and others added 3 commits December 28, 2021 10:36
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina enabled auto-merge (squash) December 29, 2021 00:50
@chapulina chapulina disabled auto-merge December 29, 2021 01:09
@chapulina chapulina merged commit 9c28568 into ign-math6 Dec 29, 2021
@chapulina chapulina deleted the ahcorde/pybind11/matrix4 branch December 29, 2021 01:09
@osrf-triage
Copy link
Copy Markdown

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏰 citadel Ignition Citadel 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🌱 garden Ignition Garden Gazebo 1️1️ Dependency of Gazebo classic version 11 scripting Scripting interfaces to Ignition

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants