Pose3_TEST.py: use 0.01 (not 0) in string test#257
Merged
scpeters merged 2 commits intogazebosim:ign-math6from Sep 30, 2021
Merged
Pose3_TEST.py: use 0.01 (not 0) in string test#257scpeters merged 2 commits intogazebosim:ign-math6from
scpeters merged 2 commits intogazebosim:ign-math6from
Conversation
Fixes gazebosim#250. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
chapulina
approved these changes
Sep 30, 2021
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Member
Author
|
I'm going to try a prerelease directly from this branch |
Contributor
The hypothesis could be right. +1, let's see how it goes the debbuilder. |
Member
Author
|
j-rivero
approved these changes
Sep 30, 2021
Codecov Report
@@ Coverage Diff @@
## ign-math6 #257 +/- ##
==========================================
Coverage 99.41% 99.41%
==========================================
Files 67 67
Lines 6347 6347
==========================================
Hits 6310 6310
Misses 37 37 Continue to review full report at Codecov.
|
Contributor
|
seems good! |
mjcarroll
pushed a commit
that referenced
this pull request
Oct 13, 2023
Fixes #257 Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
mjcarroll
pushed a commit
that referenced
this pull request
Oct 13, 2023
Fixes #257 Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
I believe this fixes #250
Summary
Pose3_TEST.pyis failing onarm64due to a-0instead of0in an expected string. This changes the constant from0to0.01to workaround the ambiguity.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge