Skip to content

Relax expectations about zero in SpeedLimiter_TEST to make ARM happy#204

Merged
j-rivero merged 1 commit intoign-math6from
relax_zero_check_arm
Mar 31, 2021
Merged

Relax expectations about zero in SpeedLimiter_TEST to make ARM happy#204
j-rivero merged 1 commit intoign-math6from
relax_zero_check_arm

Conversation

@j-rivero
Copy link
Copy Markdown
Contributor

@j-rivero j-rivero commented Mar 31, 2021

🦟 Bug fix

Fixes compilation on some ARM builds

Summary

Some ARM packaging jobs are failing with problems on the precision of zero in test under SpeedLimiter:

[ RUN      ] SpeedLimiterTest.Default
/var/lib/jenkins/workspace/ign-math6-debbuilder/build/ignition-math-6.8.0/src/SpeedLimiter_TEST.cc:60: Failure
Expected equality of these values:
  0.0
    Which is: 0
  limiter.Limit(vel, 4.0, 3.0, 1ms)
    Which is: -8.3266726846886741e-17
[  FAILED  ] SpeedLimiterTest.Default (6 ms)

With this patch the build compiles: https://build.osrfoundation.org/job/ign-math6-debbuilder/734/

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)

Note to maintainers: Remember to use Squash-Merge

@j-rivero j-rivero requested a review from scpeters as a code owner March 31, 2021 15:27
Relax expectations about zero in SpeedLimiter_TEST to make ARM happy
564f031 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero j-rivero force-pushed the relax_zero_check_arm branch from 071a209 to 564f031 Compare March 31, 2021 15:28
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏰 citadel Ignition Citadel 📜 blueprint Ignition Blueprint 🔮 dome Ignition Dome labels Mar 31, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2021 •
edited
Loading

Codecov Report

Merging #204 (739fb63) into ign-math6 (6b5c704) will not change coverage.
The diff coverage is n/a.

❗ Current head 739fb63 differs from pull request most recent head 564f031. Consider uploading reports for the commit 564f031 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           ign-math6     #204   +/-   ##
==========================================
  Coverage      99.21%   99.21%           
==========================================
  Files             65       65           
  Lines           6087     6087           
==========================================
  Hits            6039     6039           
  Misses            48       48

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b5c704...564f031. Read the comment docs.

@j-rivero j-rivero mentioned this pull request Mar 31, 2021
Closed
@j-rivero j-rivero merged commit db5edbf into ign-math6 Mar 31, 2021
@j-rivero j-rivero deleted the relax_zero_check_arm branch March 31, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scpeters scpeters scpeters approved these changes

+1 more reviewer

@chapulina chapulina chapulina approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

📜 blueprint Ignition Blueprint 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@j-rivero @scpeters @chapulina @osrf-triage