[codex] Share epic DB setup in one suite#3296
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
maphew
commented
Apr 15, 2026
maphew
left a comment
Collaborator
Author
There was a problem hiding this comment.
Reviewed — LGTM. Subtests filter by unique epic IDs so the shared store is safe. One non-blocking observation: h.t = t reassignment inside each t.Run would race if anyone later adds t.Parallel() — consider passing t into helper methods in a follow-up. Worth confirming macOS CI is green on current HEAD before merge.
Bella-Giraffety
pushed a commit
to Bella-Giraffety/beads
that referenced
this pull request
Apr 16, 2026
* test: share epic DB setup in one suite (bd-itp.5) * test: pass subtest testing.T through epic helper
Bella-Giraffety
pushed a commit
to Bella-Giraffety/beads
that referenced
this pull request
Apr 17, 2026
* test: share epic DB setup in one suite (bd-itp.5) * test: pass subtest testing.T through epic helper
mzlee
pushed a commit
to mzlee/beads
that referenced
this pull request
Apr 22, 2026
* test: share epic DB setup in one suite (bd-itp.5) * test: pass subtest testing.T through epic helper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestEpicSuiteWhy
This is the
bd-itp.5follow-on from the refactor epic. The aim was to apply the shared-suite pattern only where it is actually low-risk and measurable.cmd/bd/epic_test.gowas a live pure-DB target with repeatednewTestStore()setup and no integration-style global-state behavior. The change reduces repeated setup while preserving test intent and keeping the non-DB init test isolated.Validation
CGO_ENABLED=1 go test -tags gms_pure_go -run '^TestEpic' ./cmd/bdNotes