fix: remove ICU runtime dependency from linux-amd64 binary#2991
Merged
Conversation
The linux-amd64 release binary was the only CGO-enabled target missing the gms_pure_go build tag, causing it to dynamically link against the CI runner's libicui18n.so.74. Users on distros with newer ICU (e.g. Arch with ICU 78) got "cannot open shared object file" errors. Add the tag to match all other targets (linux-arm64, darwin, etc.), remove the now-unnecessary libicu-dev from the release workflow, and add a post-build ldd check to catch ICU linkage regressions. Fixes gastownhall#2986 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
maphew
approved these changes
Apr 6, 2026
maphew
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed. Single commit removing ICU linker flags from the linux-amd64 goreleaser target. Validated: builds cleanly with gms_pure_go tag. The goreleaser and workflow changes look correct. ✓
maphew
pushed a commit
to maphew/beads
that referenced
this pull request
Apr 6, 2026
…ep (gastownhall#2991) The linux-amd64 release binary was the only CGO-enabled target missing the gms_pure_go build tag, causing it to dynamically link against the CI runner's libicui18n.so.74. Users on distros with newer ICU (e.g. Arch with ICU 78) got "cannot open shared object file" errors. Add the tag to match all other targets (linux-arm64, darwin, etc.), remove the now-unnecessary libicu-dev from the release workflow, and add a post-build ldd check to catch ICU linkage regressions. Fixes gastownhall#2986 Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
maphew
added a commit
to maphew/beads
that referenced
this pull request
Apr 8, 2026
…ownhallGH-3126) Add docs/ICU-POLICY.md as the authoritative reference for how ICU is handled across all platforms. Update CONTRIBUTING.md and INSTALLING.md to stop listing ICU as a build requirement (it's test-only since all builds use gms_pure_go). Resolves confusion from overlapping PRs (gastownhall#2991, gastownhall#3066, gastownhall#3112) where agents and contributors were doing/undoing each other's ICU fixes without a written policy. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gms_pure_gobuild tag tobd-linux-amd64in.goreleaser.yml, matching all other CGO-enabled targets (linux-arm64, darwin-arm64, darwin-amd64). This switches from C FFI ICU regex to pure-Go stdlib regexp, eliminating the dynamiclibicui18n.sodependency while keeping CGO enabled for embedded Dolt.libicu-devfrom release workflow apt install (no longer needed).lddcheck to verify no Linux binary has ICU runtime deps (mirrors the existing macOSotoolcheck).Fixes #2986
Test plan
gms_pure_gotag compiles cleanly (verified locally)lddverification step catches any ICU linkage regression🤖 Generated with Claude Code