[codex] Fix installer ICU/CGO fallback handling#2965
Merged
maphew merged 3 commits intoApr 1, 2026
Conversation
Collaborator
Author
|
related followup WIP:
|
maphew
added a commit
to maphew/beads
that referenced
this pull request
Apr 2, 2026
* Fix shared-server init mode selection * Warn on shared-server embedded metadata mismatch * Fix installer ICU/CGO fallback handling
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gms_pure_go, avoiding unnecessary ICU header requirementsgo installor source buildsRoot Cause
The Makefile already handled platform-specific ICU/CGO behavior, but the installer fallback paths did not. Windows source installs skipped the pure-Go regex tag, and Unix fallback builds did not inherit the ICU discovery logic used elsewhere.
Impact
Users on fresh machines are less likely to hit
unicode/uregex.hbuild failures during installer fallback paths. When ICU really is missing on macOS/Linux, the installer now reports a more precise fix.Validation
bash -n scripts/install.shinstall.ps1